Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscribe block: button-only design #35708

Closed
4 tasks done
pkuliga opened this issue Feb 15, 2024 · 5 comments · Fixed by #37341
Closed
4 tasks done

Subscribe block: button-only design #35708

pkuliga opened this issue Feb 15, 2024 · 5 comments · Fixed by #37341
Assignees
@simison @pkuliga
Labels
[Block] Subscriptions [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Status] In Progress [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@pkuliga
Copy link
Contributor

pkuliga commented Feb 15, 2024 •
edited

It would be useful for placing the Subscribe block into the navigation.

Image

After the button is clicked we should open a modal to get the user email.

TODO
@pkuliga pkuliga self-assigned this Feb 15, 2024
@pkuliga pkuliga mentioned this issue Feb 15, 2024
Closed
3 tasks
@simison
Copy link
Member

simison commented Feb 15, 2024

FYI @Automattic/gold that we're looking into this and will need to do some changes in the modal.

@simison simison removed their assignment Feb 15, 2024
@crisbusquets
Copy link
Contributor

Flow

@pkuliga here's the flow. I've added how it would look like in Gutenberg and in a post.
Figma file: yJiLZt1ozJqMltHHQxR4Gc-fi-4392_12514

subscribe-block-flow

Modals update

To fit the subscribe block I've updated all the modals' width and padding to have a consistent and standardized version. Now it uses an 8pt grid for all spacings.

See current/proposal:

compare-modals

Specs: yJiLZt1ozJqMltHHQxR4Gc-fi-4392_12250

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Block] Subscriptions labels Feb 15, 2024
@crisbusquets
Copy link
Contributor

After discussing it with @pkuliga, we've updated the padding-top for the header.

Here's the updated Figma file with all the specs:

  • Subscribe modal: yJiLZt1ozJqMltHHQxR4Gc-fi-4416_3255
  • Tiers modal: yJiLZt1ozJqMltHHQxR4Gc-fi-4416_3412
  • Payment form modal: yJiLZt1ozJqMltHHQxR4Gc-fi-4416_3944
  • Categories modal: yJiLZt1ozJqMltHHQxR4Gc-fi-4416_4589

@simison
Copy link
Member

simison commented Mar 4, 2024 •
edited

Modal padding changes are now live with D138483-code

Next;

@simison simison mentioned this issue May 16, 2024
Merged
3 tasks
@pkuliga
Copy link
Contributor Author

pkuliga commented May 20, 2024

Closing this one since it was resolved here: #37341

@pkuliga pkuliga closed this as completed May 20, 2024
@pkuliga pkuliga mentioned this issue May 28, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simison simison

@pkuliga pkuliga

Labels
[Block] Subscriptions [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Status] In Progress [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Subscribe block: adds button-only style Automattic/jetpack
4 participants
@simison @jeherve @pkuliga @crisbusquets