Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groupname is required #10

Open
simondel opened this issue Apr 15, 2019 · 4 comments
Open

Groupname is required #10

simondel opened this issue Apr 15, 2019 · 4 comments

Comments

@simondel
Copy link

The groupName property is required:
image

However, the task says that the property is optional:
image

@jmezach
Copy link
Member

jmezach commented Apr 15, 2019

GroupName is required by the publish command, but it's not required for some of the other commands. I'll check if I can make that property conditionally required or something.

@jmezach
Copy link
Member

jmezach commented Apr 16, 2019

Looks like we cannot make an input parameter required only for certain scenario's, so doing this properly would require a breaking change which would involve separating out the group name used for publish and a different input for the other commands.

Would rephrasing the text in the tooltip here suffice for now so that we make it clear that group name is required for publishing scenario's?.

@simondel
Copy link
Author

I think rephrasing would make it clearer. However, I probably wouldn't fill it in the first time because Azure DevOps doesn't prompt me that I have to fill it in.

@jmezach
Copy link
Member

jmezach commented Apr 25, 2019

I've just released a new version of the extension which fixes a bug and I've modified the description of the group name field in the process. I'll keep this open to figure out a more permanent solution for this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants