Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Cannot build /packages/scripts despite following directions in CONTRIBUTING.md #704

Open
1 task done
alexdanilowicz opened this issue Feb 25, 2023 · 1 comment
Open
1 task done
Labels
bug Something isn't working

Comments

@alexdanilowicz
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When following directions in CONTRIBUTING.md, after running:

cd $PROJECT_ROOT/packages/forest && yarn run build # successful
cd $PROJECT_ROOT/packages/scripts && yarn run build # successful

I run:

cd $PROJECT_ROOT/packages/scripts && yarn run build

And get error output and cannot build the rest.

../core/src/utils/createEventsFromManifest.ts:3:29 - error TS2307: Cannot find module '@atrilabs/app-design-forest/src/componentTree?id' or its corresponding type declarations.

3 import ComponentTreeId from "@atrilabs/app-design-forest/src/componentTree?id";
                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../core/src/utils/createEventsFromManifest.ts:4:28 - error TS2307: Cannot find module '@atrilabs/app-design-forest/src/callbackHandlerTree?id' or its corresponding type declarations.

4 import CallbackTreeId from "@atrilabs/app-design-forest/src/callbackHandlerTree?id";
                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../core/src/utils/getReactManifest.ts:2:35 - error TS2307: Cannot find module '@atrilabs/react-component-manifest-schema?id' or its corresponding type declarations.

2 import ReactManifestSchemaId from "@atrilabs/react-component-manifest-schema?id";
                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 3 errors in 2 files.

Errors  Files
     2  ../core/src/utils/createEventsFromManifest.ts:3
     1  ../core/src/utils/getReactManifest.ts:2
error Command failed with exit code 2.

I actually originally had more Typescript errors, but changed my tsconfig.json in packages/scripts/ to suppress them:

    "strictNullChecks": false,
    "noImplicitReturns": false,
    "noPropertyAccessFromIndexSignature": false

Error message

N/A. Development environment.

Screenshots

Terminal output above.

Expected Behavior

I'd expect cd $PROJECT_ROOT/packages/scripts && yarn run build to run

System configuration

1. OS: Mac OS Monterrey 12.3
2. Bits: M1 chip
3. Browser: N/A
4. Atri framework version: latest
5. Virtual environment:  N/A

Steps To Reproduce

1. Clone repo fresh
2. Follow steps in CONTRIBUTING.MD

Anything else?

Thanks!

@alexdanilowicz alexdanilowicz added the bug Something isn't working label Feb 25, 2023
@welcome
Copy link

welcome bot commented Feb 25, 2023

Hello there! Welcome to the project! 💖

Thank you for opening your very first issue here. Hope you have a great time here!😄

Besides, don’t forget to ⭐ the repository, if you haven’t already!

@alexdanilowicz alexdanilowicz changed the title 🐞 🐞 Cannot build /packages/scripts despite following directions in CONTRIBUTING.md Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant