-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text is too high up for bottom bar #141
Labels
Comments
I think thats it's due to TextView in Built Padding. I will have a look at it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The guidelines call for the text to be aligned at the bottom with 10dp underneath. This library has the bottom of the text higher than that (like 13 dp)
https://material.io/guidelines/components/bottom-navigation.html#bottom-navigation-specs
If you look at the guidelines the bottom of the text is exactly aligned at 10dp. But in the library if I change the bottom padding to 0, you'll see that there is still some padding (probably built in to TextView) above the bottom of the screen (which explains the discrepancy).
The problem with this is that the text is too high and the icons will not have a gap between them and the top of the text if you use the full 24x24. Also the spacing below the text looks awkwardly larger than it should be.
If you take a screen shot of the google photos app and compare its bottombar to this library - you will see the spacing issue.
Something needs to be changed with the padding at the bottom to compensate for the textview's built in padding.
Through tweaking things it looks like bottom padding of 7dp makes the bottom of the text line up correctly at 10dp
The text was updated successfully, but these errors were encountered: