-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow cross-origin access to web server #838
Comments
Hi, yeah I'm not against making CORS a setting, I'll have to experiment a little bit with this to make sure I know what the implications of this change are. The main concern is accidentally exposing things publically, either directly or indirectly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm experimenting with creating a way to control profiles remotely (i.e. from my phone), and encountered a missing CORS header
Access-Control-Allow-Origin
error when making requests from my local web server. I'm not too familiar with how CORS or NAT should be set up to make it possible, but when I added this it worked:Reference to code:
Artemis/src/Artemis.Core/Services/WebServer/WebServerService.cs
Lines 125 to 127 in c901bce
As far as I can tell, this is basically the same as adding
Access-Control-Allow-Origin: *
to the response headers. Could there be a way expose this via settings, possibly with custom values?The text was updated successfully, but these errors were encountered: