-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backslash to Forward slash correction #199
Comments
I might send a PR, but I don't really understand the codebase that well. 🤕 |
Browsers convert backslashes to slashes when they parse I believe the right place to implement this would be in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems that browsing to a URL like this: https:// possibility.com/Clearing/Images\brnbagbk.gif (github encodes these URLs so I had to put a space after "https://")
with a backward slash will resolve properly in browsers (latest Google Chrome and Firefox tested) by changing it to a forward slash when the URL is processed. It will automatically replace the backward slashes with forward slashes.
When it comes to storing the response in WARC as well as tools retrieving the correct URL (similar to how a browser would correct the request) I am not sure of the implications. I can imagine a process where a URL that resolves 404 with a backward slash in it can be retried with the backslashes replaced with forward slashes.
From the dashboard, when viewed in Google Chrome:
What is the best way to handle this in grab-site?
The text was updated successfully, but these errors were encountered: