Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InnoSetup: During setup LTTP sprite download can be inadvertently interrupted during installation. #3204

Open
Drexl opened this issue Apr 23, 2024 · 5 comments
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.

Comments

@Drexl
Copy link

Drexl commented Apr 23, 2024

What happened?

After setup of 0.4.6 you are prompted to restart windows while LTTP sprites are still downloading, potentially interrupting the process.

What were the expected results?

All setup procedures would be completed before being prompted to restart windows.

Software

Local generation

@ThePhar ThePhar changed the title Bug: [Win] [0.4.6] During setup LTTP sprite download can be inadvertently interrupted InnoSetup: During setup LTTP sprite download can be inadvertently interrupted during installation. Apr 23, 2024
@ThePhar ThePhar added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Apr 23, 2024
@ThePhar
Copy link
Member

ThePhar commented Apr 23, 2024

Interesting. Not much work has been done on the innosetup script in a while, but if no one else does, I'll see if I can take a look when I have the time.

@alwaysintreble
Copy link
Collaborator

The installer doesn't need you to restart windows and doesn't prompt for it. I just tested it. Whatever prompted you to restart was not the Archipelago installer.

@ThePhar
Copy link
Member

ThePhar commented Apr 23, 2024

The installer doesn't need you to restart windows and doesn't prompt for it. I just tested it. Whatever prompted you to restart was not the Archipelago installer.

I presume it's the Visual C++ Redistributable actually. It would also only request a restart if it was the first time installed.

@Berserker66
Copy link
Member

Berserker66 commented Apr 23, 2024

It is visual C++ redist, yes. The way it works is that when a windows component like it is updated or installed a flag is set that will cause all future setups, including ours, to ask for a restart. You can get the same if you run any other windows setup before the shutdown to get the same question.

@nicholassaylor
Copy link
Contributor

nicholassaylor commented Jun 3, 2024

This should be fixed as of 0.5.0 since the installer will wait for sprites to finish downloading before continuing to the end of set-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

No branches or pull requests

5 participants