displayName mod revision #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this name title/badge suffix stuff needs to be a separate feature request I still think it would be weird for display names to be associated with particular items that are equipped. While it would suffice for the needs of the ninja garb task, it would just be adding a whole other feature that isn't really needed right now. I just don't see a good design case for it ATM without it being fleshed out more and given a real purpose, so it doesn't just become something that ends up being added just for the sake of being added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156
Add a
displayNamemod that allows items to change its wearer name.e.g. Ninja garb changes the name to
???while equipped