Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ninja garb should hide player name #156

Open
Arcanorum opened this issue Jul 31, 2021 · 2 comments
Open

Ninja garb should hide player name #156

Arcanorum opened this issue Jul 31, 2021 · 2 comments
Labels
code Requires code (logic/configuration) to be created or modified. good first issue Good for newcomers
Projects

Comments

@Arcanorum
Copy link
Owner

Arcanorum commented Jul 31, 2021

Task description

Currently the ninja garb armour doesn't actual hide the display name of a player wearing it like it's item description says.

This item is intended to allow players to maintain anonymity so they can attempt surprise attacks/assassinations on other players without fear of repercussion later when they aren't wearing it.

References/notes

This should be done on the server side to avoid players being able to manually show the display name for a player entity on the client.
Where player display name is retrieved from the player entity: https://github.com/Arcanorum/dungeonz/blob/master/server/src/entities/classes/destroyables/movables/characters/Player.js#L200
Similar name change functionality (add this to the ninja garb item for when it is equipped/unequipped): https://github.com/Arcanorum/dungeonz/blob/master/server/src/entities/classes/destroyables/movables/characters/Player.js#L505

Acceptance criteria

  • When a ninja garb is equipped, that player's display name should be shown as "???" to all players in range.
  • When a player with a ninja garb equipped comes into view of a player, their display name should be shown as "???".
  • When a player wearing a ninja garb unequips it, their display name should be set to their true display name for all players in range.
  • When a player wearing a ninja garb sends a chat message, the name of the player in the chat box should be shown as "???".
@Arcanorum Arcanorum added code Requires code (logic/configuration) to be created or modified. good first issue Good for newcomers labels Jul 31, 2021
@Arcanorum Arcanorum added this to Content in Update 12 Aug 2, 2021
@Arcanorum Arcanorum added this to Backlog in Main board Aug 6, 2021
@Arcanorum Arcanorum moved this from Backlog to Ready to start in Main board Aug 7, 2021
@Arcanorum Arcanorum removed this from Content in Update 12 Aug 7, 2021
@mtrunt
Copy link

mtrunt commented Oct 17, 2021

I'd like to give this a shot.

@Arcanorum
Copy link
Owner Author

Sure

@Arcanorum Arcanorum moved this from Ready to start to In progress in Main board Oct 17, 2021
@Arcanorum Arcanorum moved this from In progress to Ready to start in Main board Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Requires code (logic/configuration) to be created or modified. good first issue Good for newcomers
Projects
No open projects
Main board
Ready to start
Development

Successfully merging a pull request may close this issue.

2 participants