-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ninja garb should hide player name #156
Labels
code
Requires code (logic/configuration) to be created or modified.
good first issue
Good for newcomers
Projects
Comments
Arcanorum
added
code
Requires code (logic/configuration) to be created or modified.
good first issue
Good for newcomers
labels
Jul 31, 2021
I'd like to give this a shot. |
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code
Requires code (logic/configuration) to be created or modified.
good first issue
Good for newcomers
Task description
Currently the ninja garb armour doesn't actual hide the display name of a player wearing it like it's item description says.
This item is intended to allow players to maintain anonymity so they can attempt surprise attacks/assassinations on other players without fear of repercussion later when they aren't wearing it.
References/notes
This should be done on the server side to avoid players being able to manually show the display name for a player entity on the client.
Where player display name is retrieved from the player entity: https://github.com/Arcanorum/dungeonz/blob/master/server/src/entities/classes/destroyables/movables/characters/Player.js#L200
Similar name change functionality (add this to the ninja garb item for when it is equipped/unequipped): https://github.com/Arcanorum/dungeonz/blob/master/server/src/entities/classes/destroyables/movables/characters/Player.js#L505
Acceptance criteria
The text was updated successfully, but these errors were encountered: