-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shownotes links hard to read on dynamic themes #7139
Comments
Actually, by default the android webview will show an underline for all links but our |
Thoughts about changing the CSS @keunes ? I think @flofriday is referring to this line
|
Thanks both! I was thinking: I prefer visually only the colour change because it's neater, but is really OK to do away with the underline? Seems yes, it's OK: It is recommended to make links blue, and to ensure good enough colour contrast. Makes me wonder how this works: If I understand correctly we can specify different things for 'normal' and 'dynamic'. Even with dynamic colour in your second screenshot I believe that the contrast is a bit on the low side. Could we somehow avoid these links from being adapted?
I think the 'normal' colours look fine, yes. |
I would keep the accent colors for links. Otherwise there is this different shade of blue that doesn't really fit the others. I would just add the underline |
Hey, just wanted to check in if there is any progress on the decision yet. |
Checklist
App version
3.3.2f (develop branch)
Where did you get the app from
Other
Android version
14
Device model
Simulator (Pixel 8)
First occurred
Since material you introduction
Steps to reproduce
Expected behaviour
The links stand out somehow
Current behaviour
They can barley be distinguished from the other text.
To be fair I don't think this is particularly the fault of Antennapod, it is much more Androids fault cause it really does select accent colors that are quite muted and very close to the primary text color.
However, I think we should still improve their readability.
Logs
No response
Possible solutions
In the screenshot below I show the current situation (left), how it would look like if we switch the links from accentColor to primaryColor (middle) or if we leave the color and just add an underline (right).
Personally, I think both solutions are fine, most other apps currently opt for underlining (Spotify for example). Also for the implementation it is open if we should change that behaviour just for dynamic colors as for the non dynamic themes the accent color is good enough to read.
The text was updated successfully, but these errors were encountered: