refactor: update emoji.json now includes hex, dec and unicode along with removal of AbstractEmoji and expose IEmoji
#224
Conversation
- Removes `AbstractEmoji` and exposes `IEmoji`
|
@yoobi ready for review ⚡ |
|
Neat PR, nothing more to add, really cool we don't need AbstractEmoji anymore :) |
|
Maybe I could commit on this branch to add |
|
Oh we have committed at the same time, I'll close my PR, yours is better |
Haha, whoops. I figured we might as well, I assumed you were busy so went ahead and added some. I don't think they're perfect and may need some fine tuning though. So fee free to suggest 😉 |
|
I've had the same rules even less than what you did and it worked when I tried for all 3 serializers |
Great to hear, I'll merge this in. We can test the commit hash as our version and create a new release if you're happy with the outcome 😃 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I've tried checking |
|
@yoobi not sure what the commit hash you're using points to but the latest commit hash on develop is e0369c5 so you should be using https://jitpack.io/#anitrend/android-emojify/e0369c5fae -> |
|
Oh right, I was looking at jitpack builds and the last one was pointing at |
|
I'll hold off publishing the tag till Friday in case you uncover any issues |
AniTrend Pull Request
Thank you for contributing! Please take a moment to review our contributing guidelines to make the process easy and effective for everyone involved.
Please open an issue before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working on something that might not end up being merged into the project.
Before opening a pull request, please ensure you've done the following:
developand targetsdevelop(where applicable)Types of changes
IMPORTANT: By submitting a patch, you agree to allow the project owners to license your work under the terms of the Apache License 2.0.