Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like default shell is zsh? #10

Open
jonasdroste opened this issue Dec 19, 2017 · 1 comment
Open

Looks like default shell is zsh? #10

jonasdroste opened this issue Dec 19, 2017 · 1 comment

Comments

@jonasdroste
Copy link

Hi,
while running the install script one is asked to enter the shell name.
What's your shell? [ zsh ]:

The [zsh] looks like a default value and if you just hit enter there is no check of an empty input, so the script fails.

Suggestion:
Change output to something like:
What's your shell? (0: zsh, 1: bash, ... ) [default: 0]:
And add the default check!

@Angelmmiguel
Copy link
Owner

Hello @jonasdroste,

Thank you for your suggestion. I'm thinking about removing that check. Since the bash port is not properly tested and I don't plan to continue it, I believe that it's better to remove that input :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants