Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galaxy does not seem to pick up new names with an existing id #26

Open
AndrewDWhite opened this issue May 17, 2020 · 10 comments
Open

Galaxy does not seem to pick up new names with an existing id #26

AndrewDWhite opened this issue May 17, 2020 · 10 comments

Comments

@AndrewDWhite
Copy link
Owner

Galaxy does not seem to pick up new names with an existing id determine what is going here

@AndrewDWhite
Copy link
Owner Author

A work around is in the code to add the user name as a salt. Change your username and it will change with the changed id.

@AndrewDWhite
Copy link
Owner Author

Sometimes it works:
image
When it doesn't it looks like:
image
No information is currently provided to plugins for them to retry or fix.

@petey212
Copy link

I have found the best path when I have added a new game/platform is to look up the games within IGDB.com.

This is the database that Gog Galaxy is using and the name you have given the game has to match this exactly. The only trouble I've had is with games that have what I would call a generic name across multiple platforms. Even if you are looking specifically at in your example Xbox games, it doesn't limit the scope of it's search to that platform and if there are 2 games with the same name, it puts your game in the unknown game pile. This is not something a plugin developer can fix either as it's a problem on how Gog searches and what searches IGDB allows as well.

Occasionally I've also had a game not have an entry but IGDB is pretty easy to add an entry for your game. Funnily enough, all of the ones I've had to add are available within Moby games database so I've just done a copy pasta but imho, Gog should really be using more than one database to be honest, especially as it's also the source for the critic reviews and they don't seem to have a function for adding new critic reviews on IGDB.

@AndrewDWhite
Copy link
Owner Author

The only real solution I can think of is to add a feature to try to validate if galaxy will like the name. It would be easier if there was either an api into galaxy for this information or integration for plugin GUIs to allow the user to start this operation since it would be expensive to automatically do this for them.

@AndrewDWhite
Copy link
Owner Author

Note that it appears that their db of games looks like requests of the following:
https://gamesdb.gog.com/platforms/test/external_releases/8977823a3b2829f6030c0b8f1b49e73e7595b622

See for more info:
gogcom/galaxy-integrations-python-api#10
gogcom/galaxy-integrations-python-api#72

@AndrewDWhite
Copy link
Owner Author

Added a script to pull this info from the plugin cache and provide a link to the galaxy db for user's manual comparison. Potential for automating this but is a starting point to see what is going on.
py -3.7-32 BackendInfoPage.py

https://github.com/AndrewDWhite/GalaxyGenericImporterPlugin/blob/08bfa9deb422e103516ba31f4362a6e0f6b9a001/src/BackendInfoPage.py

@AndrewDWhite
Copy link
Owner Author

It appears that the reverse will also happen. Existing names will not always be used with new ids:
For Chrono Trigger Compare:
https://gamesdb.gog.com/platforms/steam/external_releases/613830
https://gamesdb.gog.com/platforms/test/external_releases/54a7120ffbafffe784da155cca7a7aaa5549aba4

@AndrewDWhite
Copy link
Owner Author

AndrewDWhite commented Oct 11, 2021

Improvements to gogcom/galaxy-integrations-python-api#95 may help with this. Note that this way of creating the issue isn't the only way for a new name to an id to associate to unknown game issue to appear as this can be triggered for completely new entries (especially when adding them into galaxy in bulk).

@AndrewDWhite
Copy link
Owner Author

AndrewDWhite commented Oct 18, 2021

The new tools in the cache dump webpage should help with looking at what is Unknown.

  • in the plugin folder run py -3.7-32 BackendInfoPage.py to generate the page
  • Open up generated cache.html and use the search to find any items which galaxy is choking on

Look in GalaxyClient.log for GamesDbPiecesPullerByRelease retrieved response code 404 or other errors
Copy that id without the leading test_ into the search bar for info on what was sent

If you are missing pip tools run python -m pip install pip-tools .

@AndrewDWhite AndrewDWhite moved this from To do to In progress in Development kanban Oct 18, 2021
@AndrewDWhite AndrewDWhite moved this from In progress to To do in Development kanban Nov 20, 2021
@AndrewDWhite
Copy link
Owner Author

This is related to and may possibly be resolved by this being implemented depending on the details.
gogcom/galaxy-integrations-python-api#177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants