Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing session while querying causes deadlock #1

Open
RoyalMCPE opened this issue Aug 17, 2022 · 2 comments
Open

Editing session while querying causes deadlock #1

RoyalMCPE opened this issue Aug 17, 2022 · 2 comments

Comments

@RoyalMCPE
Copy link

Calling InsertComponent or similar that add/remove components from the session while querying causes a deadlock.

This seems to be due to the (query)[https://github.com/AndreasHGK/Peex/blob/14262052507231a0fa059e55837d584da6e12a8d/session.go#L156] calling unlock on defer rather than before the passed function is called.
@AndreasHGK
Copy link
Owner

Sorry, I did not see this. I am aware that this happens at the moment, and I will be changing some things around to fix this in the future.

@didntpot
Copy link

Any updates @AndreasHGK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RoyalMCPE @AndreasHGK @didntpot