Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turning this code into pip package #3

Open
marta-sd opened this issue Nov 30, 2019 · 3 comments
Open

Turning this code into pip package #3

marta-sd opened this issue Nov 30, 2019 · 3 comments

Comments

@marta-sd
Copy link
Contributor

Hi @Andras7
I reorganized your code a little bit to make it easily installable with pip.. You can install it with:
pip install git+https://github.com/marta-sd/word2vec-pytorch.git

You can take a look at my version here
If you are interested in this kind of contribution I'd be happy to create a PR

Best
MSD
@Andras7
Copy link
Owner

Andras7 commented Dec 2, 2019

Hi @marta-sd
I really like your changes. Thank you!

@marta-sd marta-sd mentioned this issue Dec 6, 2019
Merged
@marta-sd
Copy link
Contributor Author

marta-sd commented Dec 6, 2019

Happy to hear that!

I created a PR with my changes ( #6 )

@Andras7
Copy link
Owner

Andras7 commented Dec 8, 2019

I accepted, the code looks much better.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marta-sd @Andras7