Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New search statistics display proposal #2049

Open
agrogers opened this issue Jan 13, 2022 · 3 comments · May be fixed by #2061
Open

New search statistics display proposal #2049

agrogers opened this issue Jan 13, 2022 · 3 comments · May be fixed by #2061

Comments

@agrogers
Copy link
Contributor

agrogers commented Jan 13, 2022

I have been working on a new search results window. It is mostly working but has more than a few problems which I might not be able to resolve by myself. I thought I would post my progress here to get some feedback about what others might find useful.

What currently works is:

  • Search hits now highlight correctly. That is, whole words are highlighted even when searching using the wildcard *
  • The results are broken down into By Book and By Word totals
  • Clicking the By Book book button changes to the Results list and scrolls to the selected book
  • By Word summary is presently based on the highlighted words. That makes sense sometimes but not so much for Strongs searches because, as can be seen, the highlighted words have a lot extra unneeded words.

To do:

  • The By Word button is supposed to filter the search results.
  • Cleanup the strongs words to try and get a more useful list (eg merge, 'will we prevail', 'prevailed', 'have prevailed' into the single word 'prevail'
  • Add more statistics?

image

image

image

PS: @tuomas2 , my recent comments about the need for a search list as well as a pseudo document search list is, I think, strengthened by this proposal. That is, having a standard dialog to show the results in also allows us to show stats like these. But perhaps, we could provide an option on the search form itself that allows the user to choose what search display he/she wants to see.

@tuomas2
Copy link
Contributor

tuomas2 commented Jan 13, 2022

I would imagine that implementing this UI too in js side would be easier (though perhaps this is not too difficult in android side either). Also, if implemented in js side, different views could be displayed at the same time, if different views are opened in separate windows (like links can be opened in a new window).

@tuomas2
Copy link
Contributor

tuomas2 commented Jan 13, 2022

Though if you are already implementing this, maybe we can consider another path too...
Or maybe we just don't implement #611 in any near future.

@tuomas2
Copy link
Contributor

tuomas2 commented Jan 13, 2022

Looks nice btw :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants