Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Dropdown is not working #134

Open
matheusgrieger opened this issue Aug 1, 2019 · 6 comments
Open

Dropdown is not working #134

matheusgrieger opened this issue Aug 1, 2019 · 6 comments

Comments

@matheusgrieger
Copy link

I've followed the docs on implementing a Dropdown, but it is not appearing when I click the trigger. Below is the code I'm using for that:

<Column>
  <Dropdown isAlign="right" isPulled="right">
    <DropdownTrigger>
      <Button isColor="primary">
        <span>Button label</span>
        <span className="icon">
          <FontAwesomeIcon icon={['fal', 'chevron-circle-down']} />
        </span>
      </Button>
    </DropdownTrigger>
    <DropdownMenu>
      <DropdownContent>
        <DropdownItem tag="a">
          Menu item
        </DropdownItem>
      </DropdownContent>
    </DropdownMenu>
  </Dropdown>
</Column>

Do I need to implement the opening and closing on click by myself?

Versions

[email protected]
[email protected]
[email protected]

@juhana
Copy link

juhana commented Sep 11, 2019

The example in the documentation has a custom implementation for opening and closing so I assume that's what you have to do.

<Dropdown isActive={isDropdownOpen}>

The documentation strongly implies that isActive is needed only if you want the dropdown to be permanently open, so maybe the wording should be tweaked there if that's not really the case.

@matheusgrieger
Copy link
Author

Yeah, that's where my doubt originated from. I have a custom implementation, though. Thanks!

@AlgusDark
Copy link
Owner

I will rewrite Bloomer to make it lighter than it is now and it will be easier to implement new Bulma.

At first wanted to create it with styled components but it was so hard to keep track to changes on Bulma :/

@matheusgrieger
Copy link
Author

Wouldn't styled components break theming capabilities with Bulma variables?

@matheusgrieger
Copy link
Author

By the way, if there's any support I can provide, be it in dev or test, I'm up for it!

@AlgusDark
Copy link
Owner

Wouldn't styled components break theming capabilities with Bulma variables?

My idea was to transform all sass logic into styled components css and use theming based on that. Too crazy to maintain but was very interesting doing it. Better is to wait for Bulma to use css variables.

By the way, if there's any support I can provide, be it in dev or test, I'm up for it!

Of course. If you have knowledge with lerna, would be interesting doing this a mono repo with Bloomer and Bloomer page. I will start doing all the tooling for Babel and eslint+TS.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants