Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null check operator used on a null value using in Router constructor, RouteNode constructor #6

Open
ifuterman opened this issue Apr 22, 2021 · 3 comments

Comments

@ifuterman
Copy link

Constructor has notation:
Router({String? basePath, Future notFoundHandler(Request request)?})
That means that the notFoundHandler value can be null. In aexamples, you use default parameters (null). But in constructor you use
: _unmatchedController = notFoundHandler!

@ifuterman ifuterman changed the title Exception in router constructor Null check operator used on a null value using in Router constructor, RouteNode constructor Apr 22, 2021
@ifuterman
Copy link
Author

ifuterman commented Apr 22, 2021

RouteNode(List<RouteSpecification?> specs, {int depth = 0, RegExp? matcher}) {
patternMatcher = matcher!;
But you use it with null value in Router.didAddToChannel

@AldrinMathew
Copy link
Owner

AldrinMathew commented Apr 22, 2021

@ifuterman

Thanks for reporting this. I have already encountered this issue on my end. The entire Aqueduct (Liquidart was supposed to be the revival of Aqueduct) package was a nightmare to migrate to Null Safety with more than 6000 errors showing up during migration. It took me 4 consecutive days of work to resolve all of those. I rescheduled all of my other projects to accommodate this. I hoped that the migration to null safety will prepare the package for publishing. Little did I know that the entire Aqueduct codebase is absolutely messed up. I have been trying to solve some list-related errors for the past 2 days, only to find out that those errors have been present in the project for more than 8 months. And I am all alone working in this project which makes it even worse.

@AldrinMathew
Copy link
Owner

@ifuterman

Please read Issue 7: Liquidart will be rewritten from scratch to understand the status of this issue and the Liquidart project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants