Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update skipped for large row heights #834

Open
4 tasks done
pbaern opened this issue Oct 23, 2023 · 0 comments
Open
4 tasks done

Update skipped for large row heights #834

pbaern opened this issue Oct 23, 2023 · 0 comments

Comments

@pbaern
Copy link

pbaern commented Oct 23, 2023

Describe the bug

Since a recent commit to the RecycleScroller, no update event is emitted if the user scrolls away from the startIndex less than the minItemSize. But for large rows, this minItemSize can be larger than the height of the scroller, so when scrolling to the bottom of the first row (making the second row visible) no update event is triggered.

This is not a problem when increasing the buffer prop to at least the row height, but it should be handled automatically by the component.

Reproduction

Scroll to the second row for rows of height larger than the height of the scroller/page. Observe that the initially emitted update has an end index of 1 and no new update event is emitted when reaching the second row.

System Info

OS: Any, Browser: Any

Used Package Manager

npm

Validations
knime-github pushed a commit to knime/knime-ui-table that referenced this issue Oct 23, 2023
@pbaern
UIEXT-1346: Emit scroll update events for large rows
9850c93 
Increased the buffer so that the end index of the first scroll event is
at least 2. There exists a piece of code in the Recycle scroller which
prevents an update event to be emitted when the user scrolls less than a
row height. So when scrolling to the second row it should already be
loaded (i.e. the first emitted end index should be 2). The change can be
reverted when Akryum/vue-virtual-scroller#834
is resolved.

UIEXT-1346 (Adjust max table height logic to account for row height)
knime-github pushed a commit to knime/knime-ui-table that referenced this issue Oct 24, 2023
@pbaern
UIEXT-1346: Emit scroll update events for large rows
e757746 
Increased the buffer so that the end index of the first scroll event is
at least 2. There exists a piece of code in the Recycle scroller which
prevents an update event to be emitted when the user scrolls less than a
row height. So when scrolling to the second row it should already be
loaded (i.e. the first emitted end index should be 2). The change can be
reverted when Akryum/vue-virtual-scroller#834
is resolved.

UIEXT-1346 (Adjust max table height logic to account for row height)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pbaern