Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version numbers broken on macOS #69

Open
core-code opened this issue Mar 29, 2020 · 2 comments
Open

version numbers broken on macOS #69

core-code opened this issue Mar 29, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@core-code
Copy link

i've downloaded version 0.1.19 but when selecting it in the Finder, it claims to be version 0.1.0:

Screenshot 2020-03-29 at 22 02 02

neither the CFBundleShortVersionString (0.1.0) nor the CFBundleVersion (20200301.105137) have any correlation with the real version number 0.1.19

@core-code core-code added the bug Something isn't working label Mar 29, 2020
@jbolda
Copy link
Collaborator

jbolda commented Mar 31, 2020

I believe that is technically the tauri app shell version:
https://github.com/Akryum/guijs/blob/master/packages/%40guijs/tauri-app/src-tauri/Cargo.toml#L3

I am not certain how to see the guijs version myself.

@core-code
Copy link
Author

the values are stored in the Info.plist file in the app bundle.

normally your build system should set them right. if it didn't you also just adjust them afterwards:


/usr/libexec/PlistBuddy -c "Set CFBundleShortVersionString ${version}" guijs.app/Contents/Info.plist
/usr/libexec/PlistBuddy -c "Set CFBundleVersion ${version}" guijs.app/Contents/Info.plist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants