Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top Browser Domain is empty if url is a file #67

Open
nicolae-stroncea opened this issue Aug 10, 2018 · 0 comments
Open

Top Browser Domain is empty if url is a file #67

nicolae-stroncea opened this issue Aug 10, 2018 · 0 comments

Comments

@nicolae-stroncea
Copy link
Member

nicolae-stroncea commented Aug 10, 2018

I was reading a pdf on firefox, and firefox showed it in top browser domains. However, because there's no real domain, it's just an activity with a colour and a time.
screenshot_2018-08-11 activitywatch

I think for a case like this, the activity should either be ignored from the "top browser domains" category, or get a custom browser domain name which lets the user know it's a file.

EDIT: Another issue is that all events without a clear domain name, will get clumped together, as they all have empty strings.It's why a custom browser domain name must be identifiable from all others, i.e if i'm reading two different pdf documents on firefox, both need to look different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant