Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom HTTP header names for w3c Trace Context (OpenTracing) #309

Open
kevinbader opened this issue Jul 9, 2020 · 0 comments
Open

Comments

@kevinbader
Copy link
Contributor

Depends on: #281

We already support the w3c Trace Context for OpenTracing-based distributed tracing. This spec requires two HTTP headers to be present:

At a minimum they MUST propagate the traceparent and tracestate headers and guarantee traces are not broken.

However, some implementations use different names for those headers, e.g., x-traceparent or my-company-trace. To support this, we should default to the standard header names but additionally allow to customize them.

Proposal:

$ export TRACEPARENT_HTTP_HEADER_NAME=my-custom-traceparent
$ export TRACESTATE_HTTP_HEADER_NAME=my-custom-tracestate
$ mix phx.server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant