Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at CI and release process improvements #1689

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

jhodges10
Copy link
Collaborator

@jhodges10 jhodges10 commented Jan 13, 2024

Link the Issue(s) this Pull Request is related to.

Summarize your change.

  • Introduce automated PR labels based on what directory code changes happen in
  • Rename the publish GitHub Action task to PyPI Publish
  • Utilize PR labels to group changes into sections on the release notes preview
  • Send Slack notifications when a release preview is generated, and when a release is ultimately published

Copy link

linux-foundation-easycla bot commented Jan 13, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (745e614) 79.84% compared to head (6ddabd2) 79.84%.
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1689   +/-   ##
=======================================
  Coverage   79.84%   79.84%           
=======================================
  Files         197      197           
  Lines       21767    21792   +25     
  Branches     4354     4358    +4     
=======================================
+ Hits        17379    17399   +20     
+ Misses       2234     2232    -2     
- Partials     2154     2161    +7     
Flag Coverage Δ
py-unittests 79.84% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 745e614...6ddabd2. Read the comment docs.

@github-actions github-actions bot added the ci label Jan 13, 2024
@jhodges10 jhodges10 marked this pull request as draft January 13, 2024 02:07
@jhodges10 jhodges10 marked this pull request as ready for review February 1, 2024 18:08
change-title-escapes: '\<*_&' # You can add #

# The template for the name of the draft release
name-template: 'v$RESOLVED_VERSION 🌈'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice rainbow :)

# default: minor
# major:
# labels:
# - 'feature'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there a feature and feat label? I know "feat" is super trendy on github right now, but tbh I'd prefer (1) full spelling (2) one way to do things. Is there some reason like tooling requires feats but not features and its out of our hands?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, we can make the tool handle either feat or feature. I'm a stickler for this kind of thing myself so I get where you're coming from.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have this whole section commented out for now, but theoretically it could help guide our semver versioning based on the labels used on PRs that get merged.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm the sort of person to spell colour with a u ;) ~~~ other than I don't get the "feat" trend so I object to using it instead of "feature" on principle, this all looks fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CI and release process Add Apple Silicon/ARM wheels
4 participants