Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Error: Have any of these errors been reported? #625

Open
ygnoh opened this issue May 6, 2024 · 9 comments
Open

Type Error: Have any of these errors been reported? #625

ygnoh opened this issue May 6, 2024 · 9 comments

Comments

@ygnoh
Copy link

ygnoh commented May 6, 2024

https://stackoverflow.com/questions/78427587/tsc-keeps-tracking-node-modules-can-anyone-help-me-resolve-this-issue

I'm using Expo, and I'm reaching out because I'm getting react-native-gifted-charts caught in the tsc error.

I understand that this is a TS configuration error, but I'm reaching out to see if you've seen any reports of it.

Thank you.

@leineveber
Copy link

Same here, nothing helps..

@ygnoh
Copy link
Author

ygnoh commented May 6, 2024

@leineveber Did you solve it? I can't find any solutions.

@ygnoh
Copy link
Author

ygnoh commented May 7, 2024

I think it's not a TS configuration error but this library.
@Abhinandan-Kushwaha Could you help?

You can reproduce the issue here:
https://github.com/ygnoh/tsc-tracking-node-modules-demo

@leineveber
Copy link

@ygnoh No, sorry, haven't found any solution yet
but for sure, it comes from the library, it doesn't have the typings for some things, for example:
image

@mhfortuna
Copy link

mhfortuna commented May 8, 2024

hey there, I was also having this issue but I used the solution from this other issue: #473
I think it is the same 🙂
Solution: #473 (comment)

@leineveber
Copy link

@mhfortuna it works, great job!

@ygnoh
Copy link
Author

ygnoh commented May 9, 2024

@mhfortuna It does not work. It looks outdated:

Applying patches...

**ERROR** Failed to apply patch for package gifted-charts-core at path
  
    node_modules/gifted-charts-core

  This error was caused because gifted-charts-core has changed since you
  made the patch file for it. This introduced conflicts with your patch,
  just like a merge conflict in Git when separate incompatible changes are
  made to the same piece of code.

  Maybe this means your patch file is no longer necessary, in which case
  hooray! Just delete it!

  Otherwise, you need to generate a new patch file.

  To generate a new one, just repeat the steps you made to generate the first
  one.

  i.e. manually make the appropriate file changes, then run 

    patch-package gifted-charts-core

  Info:
    Patch file: patches/gifted-charts-core+0.0.21.patch
    Patch was made for version: 0.0.21
    Installed version: 0.1.4

---
patch-package finished with 1 error(s).

This is because I'm using the latest version of ^1.4.10. If I use the fixed version of 1.4.7, it works.

@leineveber
Copy link

@ygnoh as far as I understand, you're trying to use patch from the "instructions", please try to do your own patch using steps from the "alternative instructions"

@ygnoh
Copy link
Author

ygnoh commented May 13, 2024

@leineveber Thanks! It works well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants