Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The notification isn't shown properly #6

Open
PalanixYT opened this issue Nov 17, 2021 · 9 comments
Open

The notification isn't shown properly #6

PalanixYT opened this issue Nov 17, 2021 · 9 comments
Labels
bug Something isn't working

Comments

@PalanixYT
Copy link

The audio player shows a normal notification, instead of using Android's built in "option" (I'm not sure what the right name would be)

Great project btw!

@AP-Atul
Copy link
Owner

AP-Atul commented Nov 18, 2021

Can you share an image of the notification? Not sure what you are mentioning.

@PalanixYT
Copy link
Author

here vinyl is using the android player space, but mpl uses standard notification space

@AP-Atul
Copy link
Owner

AP-Atul commented Nov 18, 2021

Thanks for pointing this out. Will take a look into it this weekend 🙂

@AP-Atul AP-Atul added the bug Something isn't working label Nov 18, 2021
@AP-Atul
Copy link
Owner

AP-Atul commented Nov 27, 2021

Did a bit of research. Not sure how to solve this? If you know more about this, feel free to contribute.

@AP-Atul AP-Atul added wontfix This will not be worked on and removed wontfix This will not be worked on labels Nov 30, 2021
@VishnuSanal
Copy link

If you know more about this, feel free to contribute.

I think OP was referring to this. This blog might help.

PS: @AP-Atul If you think this can be implemented to Music Player Lite, I'd love to work on this :)

@AP-Atul
Copy link
Owner

AP-Atul commented Dec 11, 2021

@VishnuSanal I would love to have someone else contributing too. You can surely do a better job than me
Feel free to change/delete/update the code.

@VishnuSanal
Copy link

@AP-Atul I tried this, but I wasn't able to get it working. I tried adding the code for MediaControls on PLayerSevice#configureMediaSession() and muting the existing notification. But, I wasn't able to get it working. I am dropping this. Good luck for implementing this from your side. :) Thanks for the amazing app, BTW :D I'll keep a look on the issues section & see if I can find anything to work on.

@Wjxfi
Copy link

Wjxfi commented Jan 2, 2023

https://github.com/MaximillianLeonov/Musicmax did it

@Wjxfi
Copy link

Wjxfi commented Feb 20, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants