Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod list is not saved after v10 #33

Open
enfJoao opened this issue Jul 12, 2022 · 8 comments
Open

Mod list is not saved after v10 #33

enfJoao opened this issue Jul 12, 2022 · 8 comments
Assignees
Labels
discussion Discussion can be anything

Comments

@enfJoao
Copy link

enfJoao commented Jul 12, 2022

Describe the bug
After the last updates, I set the extracted mods folder, click refresh and the mods show.
If I close the app, I have to refresh again for the mods to show.

@ALIENQuake ALIENQuake added the discussion Discussion can be anything label Jul 12, 2022
@ALIENQuake
Copy link
Owner

It was always like that, can you be more specific?

@enfJoao
Copy link
Author

enfJoao commented Jul 12, 2022

I don't thing I ever had to refresh this list on app load...
image

@ALIENQuake
Copy link
Owner

Ach yes, the initial tp2+metadata list was displayed at the start of the app but only because it was only partial list, without actual mod components. Since the partial scan took seconds to finish, it was no problem enabling it to be executed immediately after application launch without require user interaction. But now the scan is full-scan, including all mod data and it can take minutes to finish so I can't execute it because user might want to do other things (changing settings, download mods etc).

If you don't care how long the scan will take, I think that new feature is required: an option to launch mod scanning immediately after application is launched. Right?

@enfJoao
Copy link
Author

enfJoao commented Jul 12, 2022

It's just an opinion, but this can go two ways:

  1. Assume every time we open the app it will be a fresh setup
  2. Assume the user is completing a previous unfinished setup

If the setup is always new, don't show anything until the user loads it.
If the app wants to save what the user had selected before, then it needs to save everything and load then every time.

@ALIENQuake
Copy link
Owner

I"m afraid that such distinction is not possible. How can PI know if the user wants to preforms a clean installation vs 'completing a previous unfinished setup'?

@enfJoao
Copy link
Author

enfJoao commented Jul 12, 2022

The app designer will decide :)
Not the user.

@waebbl
Copy link

waebbl commented Jul 12, 2022

That's not a solution in this case. It can lead to buggy behaviour if the programmer decides to default to one distinction, but the user actually wanted the other one.
Don't patronize the user if it's not absolutely necessary. The user is the master of it's system, not the programmer.

@ALIENQuake
Copy link
Owner

I lead towards less hardcoded/forced behavior of the app. I'm perfectly fine with the extra option so the scanning will be instant but having extra login to distinguish such edge case is not something that I would like to introduce.

I will create a new topic with a clear description of the new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion can be anything
Projects
None yet
Development

No branches or pull requests

3 participants