Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong calculation of the profit #21

Open
oussaki opened this issue Nov 25, 2021 · 3 comments
Open

Wrong calculation of the profit #21

oussaki opened this issue Nov 25, 2021 · 3 comments

Comments

@oussaki
Copy link

oussaki commented Nov 25, 2021

If you look on how you calculated the profit

const profit = (totalDifference*priceToken0Eth)-gasCost

the profit should be calculated this way :

const profit = (totalDifferencepriceToken1Eth)-(gasCost2)

because you wanted the difference to be calculated in price of the token that you are arbitraging with
and what the point if you pay 0.02 Eth for gas and then your total profit is less of what you paid for gas

@victoralmm
Copy link

The bot still working nowadays?

@skswain96
Copy link

The bot still working nowadays?

Did you get this working on local?

@bmwmenthusiast
Copy link

The bot still working nowadays?

Is it working? Am about to try to set it up and get it all figured out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants