Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Cannot find module 'babel-plugin-add-module-exports' on 1.0.1 #76

Open
EsanLe opened this issue Apr 16, 2019 · 20 comments
Open

Error: Cannot find module 'babel-plugin-add-module-exports' on 1.0.1 #76

EsanLe opened this issue Apr 16, 2019 · 20 comments

Comments

@EsanLe
Copy link

EsanLe commented Apr 16, 2019

New package with version 1.0.1 is broken

When I run babel src -d lib --delete-dir-on-start, the console shows:

{ Error: Cannot find module 'babel-plugin-add-module-exports'
    at Function.Module._resolveFilename (module.js:538:15)
    at Function.Module._load (module.js:468:25)
    at Module.require (module.js:587:17)
    at require (internal/module.js:11:18)
    at Module._compile (module.js:643:30)
    at Object.Module._extensions..js (module.js:654:10)
    at Module.load (module.js:556:32)
    at tryModuleLoad (module.js:499:12)
    at Function.Module._load (module.js:491:3) code: 'MODULE_NOT_FOUND' }

And the new package is empty, I try to revert to 1.0.0 everything worked.

npm i [email protected]

ls -al ./node_modules/babel-plugin-add-module-exports/
total 8
drwxr-xr-x    5 eiddle staff   160 Apr 17 00:46 .
drwxr-xr-x 1970 eiddle staff 63040 Apr 17 00:49 ..
-rw-r--r--    1 eiddle staff  3353 Oct 26  1985 README.md
drwxr-xr-x    3 eiddle staff    96 Apr 17 00:46 node_modules
-rw-r--r--    1 eiddle staff  2116 Apr 17 00:46 package.json
@EsanLe EsanLe changed the title Error: Cannot find module 'babel-plugin-add-module-exports' Error: Cannot find module 'babel-plugin-add-module-exports' on 1.0.1 Apr 16, 2019
@Macil
Copy link

Macil commented Apr 16, 2019

It looks like the compiled javascript is entirely missing from the published package.

$ ls -a node_modules/babel-plugin-add-module-exports/
.            ..           README.md    package.json

@ljharb
Copy link

ljharb commented Apr 16, 2019

cc @lijunle - see #71

@dtothefp
Copy link

Yup this didn't get compiled to lib and there is no 1.0.1 release tag on the repo..confusing

@ljharb
Copy link

ljharb commented Apr 17, 2019

@dtothefp because the other person with publish access doesn’t have commit access.

@shinnqy
Copy link

shinnqy commented Apr 17, 2019

+1, only package.json and ReadMe.md, no lib directory

@EsanLe
Copy link
Author

EsanLe commented Apr 17, 2019

@ljharb plz fix it ASAP

@ljharb
Copy link

ljharb commented Apr 17, 2019

@EiddleChen I’m not one of the people with commit or publish access, unfortunately, or it’d have been fixed half a year ago :-)

@EsanLe
Copy link
Author

EsanLe commented Apr 17, 2019

@ljharb oh cool, but who publish the empty package to production tomorrow? Some of my project cannot build now, Can anyone unpublish the 1.0.1 verison package? Is your repository hacked?

@ljharb
Copy link

ljharb commented Apr 17, 2019

No, as i said, @lijunle has publish access but not commit access. Everything’s fine, it’s just a bug.

@EsanLe
Copy link
Author

EsanLe commented Apr 17, 2019

@lijunle plz publish a new package or unpublish 1.0.1, my projects dont have lock files, so its best to wait for you to fix it

@dtothefp
Copy link

@EiddleChen just remove the ^ in front of your dependency so you are locked at 1.0.0

@lijunle
Copy link
Contributor

lijunle commented Apr 17, 2019

Let me unpublish the version 1.0.1 to mitigate it.

@lijunle
Copy link
Contributor

lijunle commented Apr 17, 2019

Version 1.0.1 is unpublished.

@EsanLe
Copy link
Author

EsanLe commented Apr 17, 2019

After run npm update everything worked, thx!

@kopax
Copy link

kopax commented Apr 17, 2019

After run npm update everything worked, thx!

I did it and nothing changed, still having this issue.

Version 1.0.1 is unpublished.

No it is not, I've just installed it.

I try to revert to 1.0.0 everything worked.

True

Thanks for sharing this.

@ljharb
Copy link

ljharb commented Apr 17, 2019

@lijunle either way, could you merge #71 into your fork and publish it as v1.0.2? That should address all the issues.

@lijunle
Copy link
Contributor

lijunle commented Apr 17, 2019

Sorry about version 1.0.1, I just published 1.0.2. Please try again.

@lijunle
Copy link
Contributor

lijunle commented Apr 17, 2019

@ljharb I invited you to be the maintainer for the NPM package.

@ljharb
Copy link

ljharb commented Apr 17, 2019

@lijunle Thanks! Until we hear from @59naga, would it be OK if i also got commit on your fork? then we can ensure that your fork remains the source of truth until this repo can be updated.

@lijunle
Copy link
Contributor

lijunle commented Apr 17, 2019

@ljharb You are now a collaborator of my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants