Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle babel-preset-env 7.4.3 #74

Closed
wants to merge 1 commit into from

Conversation

TheLudd
Copy link

@TheLudd TheLudd commented Apr 4, 2019

[email protected] has changed the format of how default exports
are generated. This change makes sure the tests pass with the dependency
upgraded.

closes #73

`[email protected]` has changed the format of how default exports
are generated. This change makes sure the tests pass with the dependency
upgraded.

closes 59naga#73
@ljharb
Copy link

ljharb commented Apr 4, 2019

Duplicate of #70.

Copy link
Contributor

@lijunle lijunle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not worked in this project for a long time. Roughly looked at the changes, they seems fine.

@lijunle
Copy link
Contributor

lijunle commented Apr 6, 2019

#70 is better with some unit tests.

@TheLudd
Copy link
Author

TheLudd commented Apr 6, 2019

@lijunle Sure, the case with mine is that the dependency was upgraded and existing tests failed so I made them pass again

@lijunle
Copy link
Contributor

lijunle commented Apr 6, 2019

I don't think #70 is fixing the existing unit tests. It is adding new unit tests to cover the new case.

@TheLudd TheLudd closed this Jan 14, 2020
@ljharb
Copy link

ljharb commented Jan 14, 2020

Please reopen this, in case the maintainer ever comes back.

@TheLudd
Copy link
Author

TheLudd commented Jan 14, 2020

As mentioned, there is already another PR open that solves the issue, in exactly the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest babel-preset-env (7.4.3) breaks this plugin
3 participants