Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible leakage: Need to clip (theta + margin)? #11

Open
tamamachi opened this issue Oct 31, 2019 · 0 comments
Open

Possible leakage: Need to clip (theta + margin)? #11

tamamachi opened this issue Oct 31, 2019 · 0 comments

Comments

@tamamachi
Copy link

keras-arcface/metrics.py

Line 36 in 877ea00

target_logits = tf.cos(theta + self.m)

at this point the range of theta is 0 <= theta <= pi.
theta + m can be larger than pi, and in that case adding m results in negative penalty, leading to data leakage.
I think we shoud clip theta + m like

target_logits = tf.cos(K.clip(theta + self.m, 0, np.pi))
tchaye59 added a commit to tchaye59/keras-arcface that referenced this issue May 9, 2022
@tchaye59
Fix to Possible leakage discussed at 4uiiurz1#11
60b4ab0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tamamachi