-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support https://typescript-eslint.io/rules/unbound-method in lit/no-template-arrow
rule
#188
Comments
if i understand correctly, this is because if you do: html`
${this.someMethod}
`;
i do wonder if we'll be forever playing catch up with that rule since it conflicts directly with how lit code is written. maybe we should just recommend turning the tseslint rule off? |
Correct. The jest plugin I link to disables it where it does make sense in the context of jest.
I think it only conflicts with code inside templates, right? Outside of templates, it is a perfectly valid rule? |
what i mean is the i think we should just remove it from the recommended rule set and users of tseslint's recommended config would just not enable it ( anyone who does want to enable it should probably disable |
This is similar to https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/unbound-method.ts
The jest plugin checks whether the unbound method is valid in the context of jest, or it falls back to the typescript-eslint/unbound-method rule.
It would be helpful if the
lit/no-template-arrow
rule did the same. Especially now that the latesteslint-config-standard-with-typescript
version now includes the@typescript-eslint/unbound-method
rule.The text was updated successfully, but these errors were encountered: