Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments and Nulls #187

Open
garfieldmoore opened this issue Jun 17, 2020 · 2 comments
Open

Comments and Nulls #187

garfieldmoore opened this issue Jun 17, 2020 · 2 comments

Comments

@garfieldmoore
Copy link

garfieldmoore commented Jun 17, 2020

I have extracted a schema from an API. However, graphdoc fails to parse for 3 reasons;

  1. there is a "\uFFD" character
  2. The schema had multi-line comments i.e. see below for example from the schema

"""
The Date scalar type represents a year, month and day in accordance with the
ISO-8601 standard.
"""
scalar Date

  1. there are nulls

For the first issue i converted to utf-8
then I replaced all occurences of null with "null"
and finally I removed the comments

This worked and graphdoc produces the documentation but it would be great the tool could parse this schema.

I used the npm package get-graphql-schema to produce the schema so unsure if some of these issues are due to that package producing an invalid schema files.

@MrOrz
Copy link

MrOrz commented Jun 23, 2020

For comments you can see #64 (comment)

@bsmedberg-xometry
Copy link

I have PRed updated dependencies to fix this issue at #259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants