Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to postcss 7.x #103

Open
Olena-Stotska opened this issue Aug 4, 2018 · 3 comments
Open

Upgrade to postcss 7.x #103

Olena-Stotska opened this issue Aug 4, 2018 · 3 comments

Comments

@Olena-Stotska
Copy link

Could you please upgrade deps to use postcss 7.x?

Actually the better solution here would be moving postcss from dependencies to peerDependencies, as this library doesn't encapsulate postcss API, it's just a plugin. Also I'd recommend to enable https://renovatebot.com/ on github, it will make sure that your deps are always up to date

@stalniy
Copy link

stalniy commented Aug 19, 2018

I've just checked, all tests pass with postcss 7.x, so should be pretty easy to do

stalniy added a commit to stalniy/postcss-sprites that referenced this issue Aug 19, 2018
@stalniy
Copy link

stalniy commented Aug 19, 2018

I integrated renovate. The last thing you need to do is to enable it Settings > Integrations & services

@erredeco
Copy link

erredeco commented Dec 6, 2018

On my package.json I have:

"gulp-postcss": "^8.0.0",
 "postcss-sprites": "^4.2.1",

and I got the error:

Unknown error from PostCSS plugin. Your current PostCSS version is 7.0.6, but postcss-sprites uses 5.2.18. Perhaps this is the source of the error below
[...]
Stack:
TypeError: postcss.decl is not a function

Is this error related?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants