Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: Is config.php value NameIDFormat no longer used? #51

Open
darynmitchell opened this issue Dec 7, 2022 · 0 comments
Open

Q: Is config.php value NameIDFormat no longer used? #51

darynmitchell opened this issue Dec 7, 2022 · 0 comments

Comments

@darynmitchell
Copy link
Contributor

Q: Should NameIDFormat be removed from the config file?

Details:

Commit 7cdac60 introduced per-tenant nameID format, stored in DB and defaulting to persistent

The config file still has a value NameIDFormat

    'sp' => [

        /*
        |--------------------------------------------------------------------------
        | NameID format.
        |--------------------------------------------------------------------------
        |
        | Specifies constraints on the name identifier to be used to
        | represent the requested subject.
        |
        */

        'NameIDFormat' => 'urn:oasis:names:tc:SAML:2.0:nameid-format:persistent',

But I think that value is now ignored.
Is that correct?

If so I can open a PR to remove that from config.php

@darynmitchell darynmitchell changed the title Q: Config Q: Is config.php value NameIDFormat no longer used? Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant