-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebUI is missing quotes on placeholder attributes #1873
Comments
This issue is stale because it has been open for 90 days with no activity. |
This issue was closed because it has been inactive for 14 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example when
![image](https://private-user-images.githubusercontent.com/3107569/297882832-22db34a6-9459-48ab-a5e4-d43d30ef86cf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg0MjkyMzksIm5iZiI6MTcxODQyODkzOSwicGF0aCI6Ii8zMTA3NTY5LzI5Nzg4MjgzMi0yMmRiMzRhNi05NDU5LTQ4YWItYTVlNC1kNDNkMzBlZjg2Y2YucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MTVUMDUyMjE5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NGQ5MDc2Y2U2YjQzN2NhYzdiMmExMzM3MzhjMDRjM2JmZTVmMTBjYWFkYzRiN2I1OTQ5YzJlNzFiZmQ4NzJkZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.Qoo-98lTXkyG62MoM6x41u7QDEN9GQolNl2DreHxfc8)
MQTT_SERVER
is set to""
, HTML is served as<input id='mh' placeholder= value='mqtt-broker.local'>
, which the browser parses as<input id="mh" placeholder="value='mqtt-broker.local'" name="mh">
and is then shown asThe same problem also occurs for
MQTT_PORT
,MQTT_USER
andGateway_Name
.Space in the value is also problematic as it makes it show up only partialy.
i.e. for
#define Gateway_Name "OpenMQTTGateway One"
it only shows "OpenMQTTGateway" as the placeholder.Steps to reproduce the behavior:
MQTT_SERVER
,MQTT_PORT
,MQTT_USER
andGateway_Name
set as empty strings.The text was updated successfully, but these errors were encountered: