-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed time display and hash display #20
Comments
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
fix time display
https://github.com/seanjameshan/blockchain-cli/blob/master/lib/cli/util/table.js#L26
the function 'toUTCString' should be changed to 'toISOString' (the toUTCString function will lose milliseconds that lead to sha256(block) different)
It's best to get rid of 'timeStamp/1000' but use timeStamp directly
fix hash display
https://github.com/seanjameshan/blockchain-cli/blob/master/lib/cli/util/table.js#L10
this line should be changed to 'colWidths:[20,66]' to show hash fully :
#13
make judgment more precise
https://github.com/seanjameshan/blockchain-cli/blob/master/lib/blockchain/index.js#L128
this line should be changed to 'return i >= this.difficulty;' ; the hash should contains at least difficulty zero
show mining time:
https://github.com/seanjameshan/blockchain-cli/blob/master/lib/blockchain/index.js#L111
before L111
while
there should have a time:after L116
spinner.clear();
there show have a tips:The text was updated successfully, but these errors were encountered: