Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to stop ads on youtube #178

Closed
MrockzMan opened this issue Apr 6, 2024 · 12 comments
Closed

Failing to stop ads on youtube #178

MrockzMan opened this issue Apr 6, 2024 · 12 comments

Comments

@MrockzMan
Copy link

i've started getting ads again today, paid for a license today, did a clean install, still no luck
image_2024-04-05_235415933

@pquodling
Copy link

Yup, seeing the same.

@arrayoutofbounds
Copy link

same

@scoobyclub
Copy link

ditto. Youtube have found a way around it.

@brianlevin83
Copy link

Seeing the same thing here as well, on Chrome Version 123.0.6312.106 (Official Build)

@scoobyclub
Copy link

"Stands" ad-blocker seems to be working, possibly even more effectively than fadblock was. You can barely see the ads they run so fast.

@IvanLo0725
Copy link

same.

@gps137
Copy link

gps137 commented Apr 6, 2024

I believe the issue is YouTube changed the class name of the skip button to "ytp-skip-ad-button" instead of "ytp-ad-skip-button". If that's the sole issue, it should be an easy fix -- but I'm not confident enough in this being the only change to write up a pull request.

JSYOU added a commit to JSYOU/fadblock that referenced this issue Apr 9, 2024
JSYOU added a commit to JSYOU/fadblock that referenced this issue Apr 9, 2024
JSYOU added a commit to JSYOU/fadblock that referenced this issue Apr 9, 2024
@0x48piraj
Copy link
Owner

Seems like it, the update was pushed geolocally so the old patch was working for many, seems like it's time to update.

@pquodling
Copy link

So, there seems to be consensus on what caused this, and a code fix done - when will this be pushed out to a new install kit? (or instructions to update)

@pquodling
Copy link

Hello, is this thing turned on? Apparently a fix has been identified, and submitted for inclusion - but we have been waiting for a week to get this rolled out. It can't take that long to review/approve/build or whatever is required.

@0x48piraj
Copy link
Owner

The latest YouTube patch has not been deployed globally yet, so the previous version continues to function for the time being.

I've made updates to the backend, so if anyone encounters issues with the current version, they can simply update their installed FadBlock.

Here's how:

image

@0x48piraj
Copy link
Owner

The issue was resolved this morning. Closing.

Reference thread for leaving remarks regarding this issue: #182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants